HyukjinKwon opened a new pull request, #39092:
URL: https://github.com/apache/spark/pull/39092

   ### What changes were proposed in this pull request?
   
   This PR proposes to disable ANSI mode in 
`pyspark.sql.tests.connect.test_connect_functions` temporarily.
   
   This PR is sort of a followup of https://github.com/apache/spark/pull/38946 
and https://github.com/apache/spark/pull/39071
   
   ### Why are the changes needed?
   
   There are failures in `test_connect_functions` with ANSI mode on 
(https://github.com/apache/spark/actions/runs/3709431687/jobs/6288067223). I 
tried to fix but they are tricky to fix because Spark Connect does not respect 
the runtime configuration at the server side.
   
   It is also tricky to fix the test to pass in both ANSI mode on and off. 
Therefore, it disables temporarily to make other tests pass. Note that PySpark 
tests stop in the middle if one fails.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No, test-only.
   
   ### How was this patch tested?
   
   Manually verified that:
   
   ```bash
   SPARK_ANSI_SQL_MODE=true ./python/run-tests --modules pyspark-connect -p 1
   ```
   passes fine.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to