amaliujia commented on code in PR #39091:
URL: https://github.com/apache/spark/pull/39091#discussion_r1051070657
##########
sql/core/src/main/scala/org/apache/spark/sql/Observation.scala:
##########
@@ -45,7 +45,7 @@ import org.apache.spark.sql.util.QueryExecutionListener
* @param name name of the metric
* @since 3.3.0
*/
-class Observation(name: String) {
+class Observation(val name: String) {
Review Comment:
ah without `val`, `name` is treated as a method. Nice catch on this.
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/dsl/package.scala:
##########
@@ -126,6 +126,20 @@ package object dsl {
Expression.UnresolvedFunction.newBuilder().setFunctionName("min").addArguments(e))
.build()
+ def proto_max(e: Expression): Expression =
Review Comment:
Same for below
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
