zhengruifeng commented on code in PR #39068:
URL: https://github.com/apache/spark/pull/39068#discussion_r1051775801
##########
connector/connect/common/src/main/protobuf/spark/connect/expressions.proto:
##########
@@ -167,4 +169,26 @@ message Expression {
// (Optional) Alias metadata expressed as a JSON map.
optional string metadata = 3;
}
+
+ message LambdaFunction {
Review Comment:
> I think this is tricky because it's hard to provide clear guidance on what
the right approach is. Generally, the downside of the unresolved function
approach is that you're using a magic value that someone has to understand.
This knowledge is now embedded in the client and cannot be inferred when
looking at the protos.
Agreed, that is what I feel. We should avoid abusing unresolved function
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
