HyukjinKwon commented on code in PR #39041: URL: https://github.com/apache/spark/pull/39041#discussion_r1051833561
########## python/pyspark/sql/functions.py: ########## @@ -208,6 +209,7 @@ def col(col: str) -> Column: column = col +@try_remote_functions def asc(col: "ColumnOrName") -> Column: Review Comment: Actually we don't need. It uses `pyspark.sql.connect.column.Column` column but uses `pyspark.sql.column.Column` type annotation assuming that the API coverage is same. It is same for `SparkSession` too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
