cloud-fan commented on code in PR #39117:
URL: https://github.com/apache/spark/pull/39117#discussion_r1051847219
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/UnsafeRowUtils.scala:
##########
@@ -113,4 +113,29 @@ object UnsafeRowUtils {
val size = offsetAndSize.toInt
(offset, size)
}
+
+ /**
+ * Returns a Boolean indicating whether one should avoid calling
+ * UnsafeRow.setNullAt for a field of the given data type.
+ * Fields of type DecimalType (with precision
+ * greater than Decimal.MAX_LONG_DIGITS) and CalendarIntervalType use
+ * pointers into the variable length region, and those pointers should
+ * never get zeroed out (setNullAt will zero out those pointers).
Review Comment:
```suggestion
* never get zeroed out (setNullAt will zero out those pointers), because
UnsafeRow
* may do in-place update for these 2 types even though they are not
primitive.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
