HyukjinKwon commented on code in PR #39041:
URL: https://github.com/apache/spark/pull/39041#discussion_r1052134706


##########
python/pyspark/sql/observation.py:
##########
@@ -109,7 +111,9 @@ def _on(self, df: DataFrame, *exprs: Column) -> DataFrame:
         )
         return DataFrame(observed_df, df.sparkSession)
 
-    @property
+    # Note that decorated property only works with Python 3.9+ which Spark 
Connect requires.
+    @property  # type: ignore[misc]
+    @try_remote_observation

Review Comment:
   Yeah it is. The annotation will be there same but the logic of the 
annotation has to be fixed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to