amaliujia commented on code in PR #39084:
URL: https://github.com/apache/spark/pull/39084#discussion_r1052550882
##########
python/pyspark/sql/tests/connect/test_connect_basic.py:
##########
@@ -389,6 +389,21 @@ def test_schema(self):
self.connect.sql(query).schema.__repr__(),
)
+ def test_to(self):
+ # SPARK-41464: test DataFrame.to()
Review Comment:
I was thinking if we only need rich tests in server side but on client side
we just test a case pass through.
However with another though I guess we need both sides have rich tests, even
they may look redundant becaue
1. we need good coverage on client to_proto
2. we need good cover on server from_proto.
So maybe adding similar tests on both client and server sides.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
