rxin opened a new pull request, #39134: URL: https://github.com/apache/spark/pull/39134
### What changes were proposed in this pull request? This patch implements group by star. This is similar to the "group by all" implemented in DuckDB. Note that I'm not done yet. We need to decide if the appropriate syntax is star, all, or both. We also need to decide if we want to throw a nicer error message when we cannot infer the right columns. Right now it just says invalid group by expression. ### Why are the changes needed? It's nice convenience syntactic sugar for interactive sql to avoid repeating the grouping columns/expressions in group by, when they can be implicitly inferred. It actually brings SQL a little bit closer to the DataFrame API in terms of usability for aggregations. ### Does this PR introduce _any_ user-facing change? Yes. This is a user facing syntactic sugar. ### How was this patch tested? Added test cases homegrown, as well as test cases from DuckDB and Mosha. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
