jerrypeng commented on code in PR #38517:
URL: https://github.com/apache/spark/pull/38517#discussion_r1052964187
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/AsyncProgressTrackingMicroBatchExecution.scala:
##########
@@ -157,8 +172,17 @@ class AsyncProgressTrackingMicroBatchExecution(
watermarkTracker.updateWatermark(lastExecution.executedPlan)
reportTimeTaken("commitOffsets") {
// check if current batch there is a async write for the offset log is
issued for this batch
- // if so, we should do the same for commit log
- if (offsetLog.getAsyncOffsetWrite(currentBatchId).nonEmpty) {
+ // if so, we should do the same for commit log. However, if this is the
first batch executed
+ // in this run we should always persis to the commit log. There can be
situations in which
Review Comment:
will fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
