rxin commented on code in PR #39142:
URL: https://github.com/apache/spark/pull/39142#discussion_r1053728279
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/PythonUDF.scala:
##########
@@ -64,7 +64,16 @@ case class PythonUDF(
override def toString: String = s"$name(${children.mkString(",
")})#${resultId.id}$typeSuffix"
- final override val nodePatterns: Seq[TreePattern] = Seq(PYTHON_UDF)
+ private def nodePatternsOfPythonFunction: Option[TreePattern] = {
Review Comment:
just to think about future proofing - how do we prevent us from adding
another expression in the future that can be an aggregate expression but
doesn't update this location?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
