HyukjinKwon commented on code in PR #39162: URL: https://github.com/apache/spark/pull/39162#discussion_r1054964456
########## python/pyspark/sql/tests/connect/test_connect_catalog.py: ########## @@ -0,0 +1,66 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +import unittest + +from pyspark.sql import SparkSession +from pyspark.testing.pandasutils import PandasOnSparkTestCase +from pyspark.testing.connectutils import should_test_connect, connect_requirement_message +from pyspark.testing.utils import ReusedPySparkTestCase +from pyspark.testing.sqlutils import SQLTestUtils + +if should_test_connect: + from pyspark.sql.connect.session import SparkSession as RemoteSparkSession + + [email protected](not should_test_connect, connect_requirement_message) +class SparkConnectCatalogTestCase(PandasOnSparkTestCase, ReusedPySparkTestCase, SQLTestUtils): + """Parent test fixture class for all Spark Connect Catalog API related + test cases.""" + + @classmethod + def setUpClass(cls): + ReusedPySparkTestCase.setUpClass() + # Create the new Spark Session + cls.spark = SparkSession(cls.sc) Review Comment: ```suggestion super(SparkConnectCatalogTestCase, cls).setUpClass() ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
