beliefer commented on code in PR #39091:
URL: https://github.com/apache/spark/pull/39091#discussion_r1055179837
##########
python/pyspark/sql/connect/dataframe.py:
##########
@@ -45,6 +45,7 @@
UnresolvedRegex,
)
from pyspark.sql.connect.functions import col, lit
+from pyspark.sql import Observation
Review Comment:
At first, because users are used to using the Observation from pyspark.sql.
I think we better use it too.
Second, this PR only use the name of Observation, not any action of it. So,
the use is safely here.
##########
python/pyspark/sql/connect/dataframe.py:
##########
@@ -45,6 +45,7 @@
UnresolvedRegex,
)
from pyspark.sql.connect.functions import col, lit
+from pyspark.sql import Observation
Review Comment:
At first, because users are used to using the `Observation` from
pyspark.sql. I think we better use it too.
Second, this PR only use the name of `Observation`, not any action of it.
So, the use is safely here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
