HyukjinKwon commented on code in PR #39146: URL: https://github.com/apache/spark/pull/39146#discussion_r1055998235
########## python/pyspark/ml/torch/tests/test_distributor.py: ########## @@ -0,0 +1,82 @@ +from pyspark.testing.utils import PySparkTestCase +from pyspark.ml.torch.distributor import PyTorchDistributor +from pyspark.sql import SparkSession + +# Q: Do you recommend that I use pytest.mark.parametrize? It doesn't seem to be used elsewhere in this code... +class TestPyTorchDistributor(PySparkTestCase): Review Comment: Can you inherit `ReusedSQLTestCase` instead ? Then I think you can remove setUp and tearDown -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
