LuciferYang commented on code in PR #39139:
URL: https://github.com/apache/spark/pull/39139#discussion_r1056108854
##########
sql/core/pom.xml:
##########
@@ -147,6 +147,11 @@
<groupId>org.apache.xbean</groupId>
<artifactId>xbean-asm9-shaded</artifactId>
</dependency>
+ <dependency>
Review Comment:
Yes, both MAVEN and SBT tested.
Personally, I think the core module needs shaded+relocation because we don't
want protobuf version which Spark depends on to affect other third-party
projects, just like `connect`&`protobuf` module. And the SQL module only uses
the protobuf class generated in the core module, so it does not need to shaded
+ relocate again.
In fact, because Spark already uses the unified protobuf version, the
`connect` and `protobuf` module only need relocation protobuf package to keep
consistent with the relocation rules of the core module , rather than the
shaded `protobuf-java` again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
