Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/717#discussion_r12564572
--- Diff: core/src/main/scala/org/apache/spark/util/ClosureCleaner.scala ---
@@ -181,6 +184,26 @@ private[spark] object ClosureCleaner extends Logging {
}
private[spark]
+class ReturnStatementFinder extends ClassVisitor(ASM4) {
+ override def visitMethod(access: Int, name: String, desc: String,
+ sig: String, exceptions: Array[String]): MethodVisitor = {
+ if(name.contains("apply")) {
+ new MethodVisitor(ASM4) {
+ override def visitTypeInsn(op: Int, tp: String) {
+ if(op == NEW &&
tp.contains("scala/runtime/NonLocalReturnControl")) {
+ throw new SparkException("Return statements aren't allowed in
Spark closures")
+ }
+ }
+ }
+ } else {
+ new MethodVisitor(ASM4) {}
+ }
+ }
+}
+
--- End diff --
just leave one line here for spacing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
