dongjoon-hyun commented on code in PR #39204:
URL: https://github.com/apache/spark/pull/39204#discussion_r1056873471
##########
python/pyspark/sql/connect/column.py:
##########
@@ -226,7 +225,7 @@ def substr(self, startPos: Union[int, "Column"], length:
Union[int, "Column"]) -
else:
start_exp = startPos
- return F.substr(self, start_exp, length_exp)
+ return substring(self, start_exp, length_exp)
Review Comment:
Could you fix the linter failure, @zhengruifeng ?
```
annotations failed mypy checks:
python/pyspark/sql/connect/column.py:228: error: Argument 2 to "substring"
has incompatible type "Column"; expected "int" [arg-type]
python/pyspark/sql/connect/column.py:228: error: Argument 3 to "substring"
has incompatible type "Column"; expected "int" [arg-type]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
