cloud-fan commented on code in PR #39182:
URL: https://github.com/apache/spark/pull/39182#discussion_r1057418565
##########
connector/connect/common/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -378,10 +379,6 @@ message Sample {
// (Optional) The random seed.
optional int64 seed = 5;
-
- // (Optional) Explicitly sort the underlying plan to make the ordering
deterministic.
- // This flag is only used to randomly splits DataFrame with the provided
weights.
- optional bool force_stable_sort = 6;
Review Comment:
I think this PR makes more changes than simply adding a new proto message.
It makes me think that we don't really need a new proto message.
We can just have a `deterministic_order` bool flag in the `Sample` message.
If it's false, then it's a normal sample. If it's true, we try to sort first,
if can't sort, then cache the dataframe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
