grundprinzip commented on code in PR #39091:
URL: https://github.com/apache/spark/pull/39091#discussion_r1058070139
##########
connector/connect/common/src/main/protobuf/spark/connect/base.proto:
##########
@@ -181,6 +184,18 @@ message ExecutePlanResponse {
string metric_type = 3;
}
}
+
+ // This message is only used by dataframe.observe if the observation is
Observation.
+ message ObservedMetrics {
+
+ repeated ObservedMetricsObject metrics_objects = 1;
+
+ message ObservedMetricsObject {
+ string name = 1;
+ DataType schema = 2;
+ repeated string values = 3;
Review Comment:
The reason for the previous comment was not necessary to put the schema of
the row in every metric, but to figure out if it makes sense to just encode
them as literals for now.
```suggestion
repeated Expression.Literal values = 2;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
