LuciferYang commented on code in PR #39255:
URL: https://github.com/apache/spark/pull/39255#discussion_r1058080832
##########
pom.xml:
##########
@@ -827,8 +827,7 @@
<dependency>
<groupId>com.google.protobuf</groupId>
<artifactId>protobuf-java</artifactId>
- <version>${protobuf.hadoopDependency.version}</version>
- <scope>${hadoop.deps.scope}</scope>
+ <version>${protobuf.version}</version>
Review Comment:
I have tested all maven test with `-Phadoop-2` and `-Phadoop-3`, and all
tests passed.
If feasible, we don't need to explicitly add `protobuf-java` dependency and
declare `protobuf.version` in each module that requires `protobuf-java`
3.x(such as core, sql, connect and protobuf), but this also changes
`protobuf-java` version in `dev/deps/spark-deps-hadoop-x-hive-2.3` from 2.5.0
to 3.x
@gengliangwang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
