Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/5908#discussion_r30576891
--- Diff:
core/src/main/scala/org/apache/spark/storage/ExternalBlockStore.scala ---
@@ -107,13 +137,19 @@ private[spark] class ExternalBlockStore(blockManager:
BlockManager, executorId:
externalBlockManager.map(_.removeBlock(blockId)).getOrElse(true)
} catch {
case NonFatal(t) =>
- logError(s"error in removing $blockId", t)
+ logError(s"Error in removing $blockId", t)
--- End diff --
anyway please just change the logging messages to make them very explicit
that they are function calls. We should either do this, or make them English
sentences.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
