MaxGekk commented on code in PR #39239:
URL: https://github.com/apache/spark/pull/39239#discussion_r1058794838


##########
python/pyspark/pandas/tests/test_resample.py:
##########
@@ -263,7 +263,7 @@ def test_dataframe_resample(self):
     def test_series_resample(self):
         self._test_resample(self.pdf1.A, self.psdf1.A, ["4Y"], ["sum"])
         self._test_resample(self.pdf2.A, self.psdf2.A, ["13M"], ["sum"])
-        self._test_resample(self.pdf3.A, self.psdf3.A, ["18H"], ["sum"])
+        # self._test_resample(self.pdf3.A, self.psdf3.A, ["18H"], ["sum"])

Review Comment:
   It fails locally on my laptop. The test itself is weird, what's the idea of 
sum up all timestamps? If you need to compare timestamp series, just compare 
elements. Summing of dates/timestamps doesn't make any sense. Any way, so far, 
it fails. It seems somewhere in pandas code there is a dependency from time 
zone offset, or conversion from/to local timestamp is not symmetric (actually 
the conversion is not needed but we are doing it for some reason).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to