zhengruifeng commented on code in PR #39283:
URL: https://github.com/apache/spark/pull/39283#discussion_r1058805164
##########
python/pyspark/sql/connect/expressions.py:
##########
@@ -420,6 +420,59 @@ def __repr__(self) -> str:
return f"{self._name}({', '.join([str(arg) for arg in
self._args])})"
+class WithField(Expression):
+ def __init__(
+ self,
+ structExpr: Expression,
+ fieldName: str,
+ valueExpr: Expression,
+ ) -> None:
+ super().__init__()
+
+ assert isinstance(structExpr, Expression)
+ self._structExpr = structExpr
+
+ assert isinstance(fieldName, str)
+ self._fieldName = fieldName
+
+ assert isinstance(valueExpr, Expression)
+ self._valueExpr = valueExpr
+
+ def to_plan(self, session: "SparkConnectClient") -> proto.Expression:
+ expr = proto.Expression()
+
expr.update_fields.struct_expression.CopyFrom(self._structExpr.to_plan(session))
+ expr.update_fields.field_name = self._fieldName
+
expr.update_fields.value_expression.CopyFrom(self._valueExpr.to_plan(session))
+ return expr
+
+ def __repr__(self) -> str:
Review Comment:
oh, `__repr__` is still needed for now.
it's not needed in plan, but we have not handle it for expressions for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
