panbingkun commented on code in PR #39270: URL: https://github.com/apache/spark/pull/39270#discussion_r1058802006
########## core/src/main/protobuf/org/apache/spark/status/protobuf/store_types.proto: ########## @@ -18,8 +18,15 @@ syntax = "proto3"; package org.apache.spark.status.protobuf; +/** + * Developer guides: + * - Coding style: https://developers.google.com/protocol-buffers/docs/style + * - Use int64 for job/stage IDs, in case of future extension in Spark core. + * - Use `weakIntern` on string values in create new objects during deserialization. Review Comment: https://issues.apache.org/jira/browse/SPARK-41759 @LuciferYang @gengliangwang @techaddict -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
