grundprinzip commented on PR #39294: URL: https://github.com/apache/spark/pull/39294#issuecomment-1367732428
> For a breaking change which break the binary compatibility, we can add it to `MimaExcludes` after confirmation. > > How can we make braking changes in proto? Is it forbidden? generally, yes. We must not make breaking changes to retain the backward and forward compatibility of the protocol. Now, we can always decide to make a breaking change and override the workflow. This is the reason why I set this up as it's own part of the Workflow. If everything else is green and only the Buf check is read someone with the power to merge can decide to simply merge the change. Since we always compare against master from then on the build will be green again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
