dongjoon-hyun commented on code in PR #39221:
URL: https://github.com/apache/spark/pull/39221#discussion_r1060250817
##########
core/src/test/scala/org/apache/spark/SSLOptionsSuite.scala:
##########
@@ -140,6 +140,24 @@ class SSLOptionsSuite extends SparkFunSuite {
assert(opts.enabledAlgorithms === Set("ABC", "DEF"))
}
+ test("test ssl settings are set only when ssl is enabled") {
+ val conf = new SparkConf
+ val hadoopConf = new Configuration()
+ conf.set("spark.ssl.enabled", "true")
+ conf.set("spark.ssl.keyStorePassword", "password")
+ conf.set("spark.ssl.ui.enabled", "false")
+ conf.set("spark.ssl.ui.keyStorePassword", "12345")
+
+
+ val defaultOpts = SSLOptions.parse(conf, hadoopConf, "spark.ssl", defaults
= None)
+ val opts = SSLOptions.parse(conf, hadoopConf, "spark.ssl.ui", defaults =
Some(defaultOpts))
Review Comment:
Could you use more explicitly meaningful variable names instead of
`defaultOpts` and `opts`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
