HyukjinKwon commented on code in PR #39358:
URL: https://github.com/apache/spark/pull/39358#discussion_r1060326991
##########
python/pyspark/sql/tests/connect/test_parity_dataframe.py:
##########
@@ -85,10 +81,6 @@ def test_extended_hint_types(self):
def test_fillna(self):
super().test_fillna()
- @unittest.skip("Fails in Spark Connect, should enable.")
- def test_freqItems(self):
Review Comment:
For this, can we change `test_freqItems` at
`pyspark.sql.tests.test_dataframe` not to use `self.sc`? e.g.,:
```diff
- df = self.sc.parallelize(vals).toDF()
+ df = self.spark.createDataFrame(vals)```
##########
python/pyspark/sql/tests/connect/test_parity_dataframe.py:
##########
@@ -85,10 +81,6 @@ def test_extended_hint_types(self):
def test_fillna(self):
super().test_fillna()
- @unittest.skip("Fails in Spark Connect, should enable.")
- def test_freqItems(self):
Review Comment:
For this, can we change `test_freqItems` at
`pyspark.sql.tests.test_dataframe` not to use `self.sc`? e.g.,:
```diff
- df = self.sc.parallelize(vals).toDF()
+ df = self.spark.createDataFrame(vals)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
