grundprinzip commented on code in PR #39361:
URL: https://github.com/apache/spark/pull/39361#discussion_r1060525678
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/config/Connect.scala:
##########
@@ -18,14 +18,15 @@ package org.apache.spark.sql.connect.config
import org.apache.spark.internal.config.ConfigBuilder
import org.apache.spark.network.util.ByteUnit
+import org.apache.spark.sql.connect.common.config.ConnectCommon
private[spark] object Connect {
val CONNECT_GRPC_BINDING_PORT =
ConfigBuilder("spark.connect.grpc.binding.port")
.version("3.4.0")
.intConf
- .createWithDefault(15002)
+ .createWithDefault(ConnectCommon.CONNECT_GRPC_BINDING_PORT)
Review Comment:
Is there a good way to make the config builder part of the externally
dependable interface?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
