srowen commented on code in PR #39286:
URL: https://github.com/apache/spark/pull/39286#discussion_r1061695522
##########
core/src/main/protobuf/org/apache/spark/status/protobuf/store_types.proto:
##########
@@ -27,10 +27,10 @@ package org.apache.spark.status.protobuf;
enum JobExecutionStatus {
JOB_EXECUTION_STATUS_UNSPECIFIED = 0;
- RUNNING = 1;
- SUCCEEDED = 2;
- FAILED = 3;
- UNKNOWN = 4;
+ JOB_EXECUTION_STATUS_RUNNING = 1;
Review Comment:
This feels redundant to have the name in the enum class and in the constant
name?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]