mridulm commented on code in PR #37638:
URL: https://github.com/apache/spark/pull/37638#discussion_r1063072468
##########
common/network-shuffle/src/test/java/org/apache/spark/network/shuffle/RemoteBlockPushResolverSuite.java:
##########
@@ -257,6 +274,7 @@ public void
testDuplicateBlocksAreIgnoredWhenPrevStreamIsInProgress() throws IOE
pushResolver.finalizeShuffleMerge(new FinalizeShuffleMerge(TEST_APP,
NO_ATTEMPT_ID, 0, 0));
MergedBlockMeta blockMeta = pushResolver.getMergedBlockMeta(TEST_APP, 0,
0, 0);
validateChunks(TEST_APP, 0, 0, 0, blockMeta, new int[]{4}, new
int[][]{{0}});
+ verifyMetrics(4, 0, 0, 0, 0, 0);
Review Comment:
The specific testcase here is, we have duplicate blocks being sent (via
speculative execution for example), and so we want to ignore data from the
"newer" push. For example, here we stream2 would be ignored. The metrics are
not capturing it - and so we see the same result in metrics as what we see for
a successful push (what we would see for `testBasicBlockMerge`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
