ulysses-you commented on code in PR #39428:
URL: https://github.com/apache/spark/pull/39428#discussion_r1063257748


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/command/DataWritingCommand.scala:
##########
@@ -79,27 +77,6 @@ object DataWritingCommand {
     }
   }
 
-  /**
-   * When execute CTAS operators, Spark will use 
[[InsertIntoHadoopFsRelationCommand]]
-   * or [[InsertIntoHiveTable]] command to write data, they both inherit 
metrics from
-   * [[DataWritingCommand]], but after running 
[[InsertIntoHadoopFsRelationCommand]]
-   * or [[InsertIntoHiveTable]], we only update metrics in these two command 
through
-   * [[BasicWriteJobStatsTracker]], we also need to propogate metrics to the 
command
-   * that actually calls [[InsertIntoHadoopFsRelationCommand]] or 
[[InsertIntoHiveTable]].
-   *
-   * @param sparkContext Current SparkContext.
-   * @param command Command to execute writing data.
-   * @param metrics Metrics of real DataWritingCommand.
-   */
-  def propogateMetrics(

Review Comment:
   unused code



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to