[GitHub] [spark] HyukjinKwon commented on a diff in pull request #39368: [SPARK-28764][CORE][TEST] Remove writePartitionedFile in ExternalSorter

Fri, 06 Jan 2023 04:20:39 -0800 


HyukjinKwon commented on code in PR #39368:
URL: https://github.com/apache/spark/pull/39368#discussion_r1063393358


##########
sql/core/src/test/scala/org/apache/spark/sql/execution/UnsafeRowSerializerSuite.scala:
##########
@@ -125,7 +130,7 @@ class UnsafeRowSerializerSuite extends SparkFunSuite with 
LocalSparkSession {
     assert(sorter.numSpills > 0)
 
     // Merging spilled files should not throw assertion error
-    sorter.writePartitionedFile(ShuffleBlockId(0, 0, 0), outputFile)
+    sorter.writePartitionedMapOutput(0, 0, mapOutputWriter)

Review Comment:
   Oh, just read 
https://github.com/apache/spark/pull/39368?notification_referrer_id=NT_kwDOAGLXhbI1MjMzNjcxNTQ0OjY0Nzc3MDE&notifications_query=is%3Aunread#issuecomment-1373501036.
 LGTM too



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to