Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/6265#issuecomment-103571107
How would people feel about:
- Using try-with-resources where possible? I count ~50 instances, mostly in
Java tests, that could use this. In some cases it would actually mean reliably
closing resources where they weren't before (almost all in tests), and remove a
bit of code, but worth the noise?
- Trying to use `java.nio.file.Files` instead of Guava `Files` and other
things like `Objects`? Worth lessening Guava's grip on the code, or not worth
the remote risk of breakage?
- `switch` on String instead of `if-else`? 3 places where this is possible
I'm going to rule out the diamond operator change for now as there is just
too much all over.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
