zhengruifeng commented on code in PR #39451:
URL: https://github.com/apache/spark/pull/39451#discussion_r1064073611
##########
connector/connect/common/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -211,6 +211,11 @@ message SetOperation {
// Only UNION supports this option.
optional bool by_name = 5;
+ // (Optional) If to perform the Set operation and allow missing columns.
Review Comment:
cc @amaliujia
it seems that `is_all` is only used in `Intersect` and `Except`,
`by_name` and `allow_missing_columns` are only used in `Union`.
Maybe we should divide the `SetOperation` into three separate protos?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
