grundprinzip commented on code in PR #39456:
URL: https://github.com/apache/spark/pull/39456#discussion_r1064210177
##########
connector/connect/common/src/main/protobuf/spark/connect/expressions.proto:
##########
@@ -209,11 +209,15 @@ message Expression {
// (Required) Indicate if this function should be applied on distinct
values.
bool is_distinct = 3;
+ // (Required) Indicates the function should skip null values in the
determination of which
+ // row to use.
+ bool ignore_nulls = 4;
+
// (Required) Indicate if this is a user defined function.
//
// When it is not a user defined function, Connect will use the function
name directly.
// When it is a user defined function, Connect will parse the function
name first.
- bool is_user_defined_function = 4;
Review Comment:
please don't change the ids of the proto in a backwards incompatible way.
Simply make ignore nulls the 5th id.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
