MaxGekk commented on code in PR #39464:
URL: https://github.com/apache/spark/pull/39464#discussion_r1064350822
##########
core/src/main/resources/error/README.md:
##########
@@ -24,27 +24,27 @@ Throw with arbitrary error message:
### After
-`error-class.json`
+`error-classes.json`
"PROBLEM_BECAUSE": {
- "message": ["Problem %s because %s"],
+ "message": ["Problem <problem> because <cause>"],
"sqlState": "XXXXX"
}
`SparkException.scala`
class SparkTestException(
errorClass: String,
- messageParameters: Seq[String])
+ messageParameters: Map[String, String])
extends TestException(SparkThrowableHelper.getMessage(errorClass,
messageParameters))
with SparkThrowable {
- def getErrorClass: String = errorClass
+ override def getErrorClass: String = errorClass
Review Comment:
Need to override `getMessageParameters` (and return
`messageParameters.asJava`) too otherwise the example won't work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
