srielau commented on PR #35709: URL: https://github.com/apache/spark/pull/35709#issuecomment-1375811080
> Maybe we should deprecate the old `datediff` function. The new `datediff` function has a special parser rule so that it won't conflict with the old one, but I agree that 2 `datedff` functions with different syntax and semantic is weird. cc @srielau There seem to be two camps here: datediff() SQL server and friends which is the newer form. And datediff() IBM, mySQL and friends, which is the older form https://dev.mysql.com/doc/refman/8.0/en/date-and-time-functions.html#function_datediff . We have a long standing tradition of supporting diofferent spellings etc for similar/same functions. This particular one is actually rather harmless since number of arguments differ. So I propose to leave them be. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
