itholic commented on code in PR #39387:
URL: https://github.com/apache/spark/pull/39387#discussion_r1064964294
##########
python/pyspark/errors/error-classes.json:
##########
@@ -0,0 +1,7 @@
+{
+ "COLUMN_IN_LIST" : {
+ "message" : [
+ "<funcName> does not allow a column in a list"
+ ]
Review Comment:
Thanks for the comment, @HyukjinKwon .
I investigated some reference.
According to [Installing Additional
Files](https://docs.python.org/3.10/distutils/setupscript.html#installing-additional-files
) in Python documentation, seems like we can put the additional files for
handling image, config, etc by using `data_files` option when installing the
Python project.
Also, [Adding Non-Code Files for python
packaging](https://python-packaging.readthedocs.io/en/latest/non-code-files.html#adding-non-code-files)
shows an example that using JSON file when packaging the Python.
I think we can't say it's absolute standard way, but maybe we can say at
least it's generally accepted way in Python
Although I haven't see the similar Python project or standard that using
JSON file as a format for error class, I think using a json file as the error
class format is fine as it is consistent within the Apache Spark project, IMHO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
