ulysses-you commented on code in PR #39475:
URL: https://github.com/apache/spark/pull/39475#discussion_r1065329055
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/V1Writes.scala:
##########
@@ -91,32 +92,31 @@ object V1Writes extends Rule[LogicalPlan] with
SQLConfHelper {
}
private def prepareQuery(write: V1WriteCommand, query: LogicalPlan):
LogicalPlan = {
- val hasEmpty2Null = query.exists(p => hasEmptyToNull(p.expressions))
- val empty2NullPlan = if (hasEmpty2Null) {
Review Comment:
this check has no meaning now since we have already checked `WriteFiles` for
rule idempotency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
