zhouyejoe commented on code in PR #37638:
URL: https://github.com/apache/spark/pull/37638#discussion_r1066439800
##########
docs/monitoring.md:
##########
@@ -1421,6 +1421,20 @@ Note: applies to the shuffle service
- shuffle-server.usedDirectMemory
- shuffle-server.usedHeapMemory
+- Notes: below shuffle service server-side metrics are specific to the
Push-Based Shuffle
+(with `spark.shuffle.push.enabled` set as true on the client side, and with
the server side
+flag `spark.shuffle.push.server.mergedShuffleFileManagerImpl` set as the
appropriate
+org.apache.spark.network.shuffle.MergedShuffleFileManager implementation for
the Push-Based
+Shuffle to be enabled)
Review Comment:
These metrics are not related to client side configurations, as if push is
not enabled in client side, these metrics will still be shown up, but all 0.
Once server side configuration is set correctly to MergedShuffleFileManager,
these metrics will be shown up.
```suggestion
- **notes:** The metrics below are specific to push-based shuffle and only
emitted when
`spark.shuffle.push.server.mergedShuffleFileManagerImpl` is configured as
"org.apache.spark.network.shuffle.RemoteBlockPushResolver".
```
Please refer to other notes format in this file. You do need to follow the
format there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
