rmcyang commented on code in PR #37638: URL: https://github.com/apache/spark/pull/37638#discussion_r1066466341
########## docs/monitoring.md: ########## @@ -1421,6 +1421,20 @@ Note: applies to the shuffle service - shuffle-server.usedDirectMemory - shuffle-server.usedHeapMemory +- Notes: below shuffle service server-side metrics are specific to the Push-Based Shuffle +(with `spark.shuffle.push.enabled` set as true on the client side, and with the server side +flag `spark.shuffle.push.server.mergedShuffleFileManagerImpl` set as the appropriate +org.apache.spark.network.shuffle.MergedShuffleFileManager implementation for the Push-Based +Shuffle to be enabled) Review Comment: I removed the client side config in the description. As for the format for note, I'm following the format at L1408, L1399, L1392, and L1384. This is the preview after the change:  Let me know if you have further input, thanks @zhouyejoe ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
