itholic commented on code in PR #39492:
URL: https://github.com/apache/spark/pull/39492#discussion_r1066521015
##########
python/pyspark/sql/tests/connect/test_parity_dataframe.py:
##########
@@ -120,8 +120,7 @@ def test_same_semantics_error(self):
def test_sample(self):
super().test_sample()
- # TODO(SPARK-41875): throw proper errors in Dataset.to()
Review Comment:
So, it sounds like now we throws proper errors, but the test still disabled
??
If so, maybe we should say like:
```python
# TODO(SPARK-XXXXX): Implement Dataset `to`
@unittest.skip("Fails in Spark Connect, should enable.")
```
such as other disabled tests ??
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
