HyukjinKwon commented on code in PR #39462:
URL: https://github.com/apache/spark/pull/39462#discussion_r1066535751
##########
python/pyspark/sql/connect/types.py:
##########
@@ -184,3 +186,113 @@ def proto_schema_to_pyspark_data_type(schema:
pb2.DataType) -> DataType:
)
else:
raise Exception(f"Unsupported data type {schema}")
+
+
+def _need_converter(dataType: DataType) -> bool:
Review Comment:
Can we call that method directly? e.g.)
```
if isinstance(dataType, MapType):
# Different from PySpark, here always needs conversion,
# since the input from Arrow is a list of tuples.
return True
else:
return _need_converter(dataType)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
