LuciferYang commented on code in PR #39487:
URL: https://github.com/apache/spark/pull/39487#discussion_r1067650529


##########
core/src/main/scala/org/apache/spark/status/protobuf/KVStoreProtobufSerializer.scala:
##########
@@ -40,10 +41,16 @@ private[spark] class KVStoreProtobufSerializer extends 
KVStoreScalaSerializer {
 
 private[spark] object KVStoreProtobufSerializer {
 
- private[this] lazy val serializerMap: Map[Class[_], ProtobufSerDe] =
-   ServiceLoader.load(classOf[ProtobufSerDe])
-     .asScala.map(serDe => serDe.supportClass -> serDe).toMap
+  private[this] lazy val serializerMap: Map[Class[_], ProtobufSerDe[Any]] = {
+    def getGenericsType(klass: Class[_]): Class[_] = {
+      klass.getGenericInterfaces.head.asInstanceOf[ParameterizedType]
+        .getActualTypeArguments.head.asInstanceOf[Class[_]]

Review Comment:
   The result of 
   ```
   klass.getGenericInterfaces.head.asInstanceOf[ParameterizedType]
     .getActualTypeArguments.head.asInstanceOf[Class[_]]
   ```
   are 
   
   ```
   class org.apache.spark.status.RDDStorageInfoWrapper
   class org.apache.spark.status.ApplicationInfoWrapper
   class org.apache.spark.status.ApplicationEnvironmentInfoWrapper
   class org.apache.spark.status.CachedQuantile
   class org.apache.spark.status.ExecutorStageSummaryWrapper
   class org.apache.spark.status.StreamBlockData
   class org.apache.spark.status.TaskDataWrapper
   class org.apache.spark.status.JobDataWrapper
   class org.apache.spark.status.ResourceProfileWrapper
   class org.apache.spark.status.SpeculationStageSummaryWrapper
   class org.apache.spark.status.ExecutorSummaryWrapper
   class org.apache.spark.status.ProcessSummaryWrapper
   class org.apache.spark.status.RDDOperationGraphWrapper
   class org.apache.spark.status.StageDataWrapper
   ```
   This is what we need(serializerMap key)
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to