cloud-fan commented on code in PR #39523:
URL: https://github.com/apache/spark/pull/39523#discussion_r1067665831
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveGroupByAll.scala:
##########
@@ -47,25 +47,40 @@ object ResolveGroupByAll extends Rule[LogicalPlan] {
}
}
+ /**
+ * Returns all the grouping expressions inferred from a GROUP BY ALL
aggregate.
+ * The result is optional. If Spark fails to infer the grouping columns, it
is None.
+ * Otherwise, it contains all the non-aggregate expressions from the project
list of the input
+ * Aggregate.
+ */
+ private def getGroupingExprs(a: Aggregate): Option[Seq[Expression]] = {
Review Comment:
hmm why do we wrap it with `Option`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
