akpatnam25 commented on code in PR #38959:
URL: https://github.com/apache/spark/pull/38959#discussion_r1067824025
##########
common/network-shuffle/src/test/java/org/apache/spark/network/shuffle/RetryingBlockTransferorSuite.java:
##########
@@ -245,8 +269,9 @@ private static void performInteractions(List<? extends
Map<String, Object>> inte
throws IOException, InterruptedException {
MapConfigProvider provider = new MapConfigProvider(ImmutableMap.of(
- "spark.shuffle.io.maxRetries", "2",
- "spark.shuffle.io.retryWait", "0"));
+ "spark.shuffle.io.maxRetries", "2",
+ "spark.shuffle.io.retryWait", "0",
+ "spark.shuffle.sasl.enableRetries", "true"));
Review Comment:
I don't think we can follow the same pattern here as
`LevelDBHybridStoreSuite` because the test logic between the 2 cases is also
different. It would make sense to extend if the test logic didn't differ. I
ended up making the config map a private static field that can be modified at a
per test level. This should be extensible to future tests that are added that
need to add new configs as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
