mridulm commented on code in PR #37922:
URL: https://github.com/apache/spark/pull/37922#discussion_r1068470671
##########
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RemoteBlockPushResolver.java:
##########
@@ -470,6 +530,40 @@ void closeAndDeleteOutdatedPartitions(
});
}
+ void deleteMergedFiles(
+ AppAttemptShuffleMergeId appAttemptShuffleMergeId,
+ AppShuffleInfo appShuffleInfo,
+ int[] reduceIds,
+ boolean deleteFromDB) {
+ if(deleteFromDB) {
+ removeAppShufflePartitionInfoFromDB(appAttemptShuffleMergeId);
+ }
+ int shuffleId = appAttemptShuffleMergeId.shuffleId;
+ int shuffleMergeId = appAttemptShuffleMergeId.shuffleMergeId;
+ int dataFilesDeleteCnt = 0;
+ int indexFilesDeleteCnt = 0;
+ int metaFilesDeleteCnt = 0;
+ for (int reduceId : reduceIds) {
+ File dataFile =
+ appShuffleInfo.getMergedShuffleDataFile(shuffleId, shuffleMergeId,
reduceId);
+ if (dataFile.delete()) {
Review Comment:
Delete wont throw an exception - only return `false` if delete failed (I am
ignoring `SecurityException` here, since that is not relevant in this context).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
