Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/6082#issuecomment-103626876
Yeah I defer to your judgment @tgravescs . I suppose it wasn't obvious to
me this is a win in whatever a normal case is, and your test indicated it
wasn't in your case. So I'm a little uncomfortable with the logic that it
should go in because it helps in theory, and a test must be bad if it
disagrees. @ehnalis it's not true that this can't do any harm, as you even say.
Yes, you can tune away the harm in that type of case, but then you've put in
another lever to know about to get it tuned. I can appreciate the argument that
adaptiveness is likely to be better in more cases than it's worse, even at
defaults. I know start-up time is an issue. I don't object to merging to
`master`, so proceed if everyone is comfortable with the logic and defaults.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
