olaky commented on code in PR #39408:
URL: https://github.com/apache/spark/pull/39408#discussion_r1069311234
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PartitioningAwareFileIndex.scala:
##########
@@ -76,28 +76,34 @@ abstract class PartitioningAwareFileIndex(
// be applied to files.
val fileMetadataFilterOpt = dataFilters.filter { f =>
f.references.nonEmpty && f.references.forall {
- case FileSourceMetadataAttribute(_) => true
+ case FileSourceConstantMetadataAttribute(_) => true
Review Comment:
Here we do expect to only see FileSourceContant/GeneratedMetadata
attributes. It is hard to test this though in an automated fashion, and I think
actually adding an assert here is not the best idea (not filtering is a better
option than throwing an exception).
I manually verified this for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
