cloud-fan commented on code in PR #39556:
URL: https://github.com/apache/spark/pull/39556#discussion_r1069621077
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala:
##########
@@ -205,8 +200,10 @@ trait UnaryNode extends LogicalPlan with
UnaryLike[LogicalPlan] {
*/
trait BinaryNode extends LogicalPlan with BinaryLike[LogicalPlan]
-abstract class OrderPreservingUnaryNode extends UnaryNode {
- override final def outputOrdering: Seq[SortOrder] = child.outputOrdering
+trait OrderPreservingUnaryNode extends UnaryNode
+ with AliasAwareQueryOutputOrdering[LogicalPlan] {
+ override protected def outputExpressions: Seq[NamedExpression] = child.output
Review Comment:
but `child.output` has no alias at all, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
