zhengruifeng commented on code in PR #39552:
URL: https://github.com/apache/spark/pull/39552#discussion_r1070192156
##########
python/pyspark/sql/tests/test_readwriter.py:
##########
@@ -53,16 +53,23 @@ def test_save_and_load(self):
)
self.assertEqual(sorted(df.collect()), sorted(actual.collect()))
- defaultDataSourceName = self.spark.conf.get(
- "spark.sql.sources.default", "org.apache.spark.sql.parquet"
- )
- self.spark.sql("SET
spark.sql.sources.default=org.apache.spark.sql.json")
- actual = self.spark.read.load(path=tmpPath)
- self.assertEqual(sorted(df.collect()), sorted(actual.collect()))
- self.spark.sql("SET spark.sql.sources.default=" +
defaultDataSourceName)
+ try:
Review Comment:
I found that is seems not easy to split the test, since it depends on the
previous lines and I almost have to copy all the tests. So I just update the
related tickets here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
